구성원 서명에 제네릭 형식을 중첩시키지 마십시오.

Question

CA1006 : DoNotNestGenericTypesInMemberSignatures 규칙을 위반하는 다음 멤버를 구현하는 확장 클래스를 얻었습니다.

경고가 참조하는 코드는 다음과 같습니다.

CA1006 경고를 해결하기 위해 코드를 어떻게 리팩터링해야합니까?

익명 메서드, 대리자 및 람다에 대해 잘 알고 있지만 식 트리에 익숙하지 않습니다.

도움이 될 것입니다.

public static DataServiceQuery<TElement> Expand<TElement, TPropType>(this DataServiceQuery<TElement> source, Expression<Func<TElement, TPropType>> propertySelector) 
    { 
     string includeString = BuildString(propertySelector); 
     return source.Expand(includeString); 
    } 

    private static string BuildString(Expression propertySelector) 
    { 
     switch (propertySelector.NodeType) 
     { 
      case ExpressionType.Lambda: 
       LambdaExpression lambdaExpression = (LambdaExpression)propertySelector; 
       return BuildString(lambdaExpression.Body); 

      case ExpressionType.Quote: 
       UnaryExpression unaryExpression = (UnaryExpression)propertySelector; 
       return BuildString(unaryExpression.Operand); 

      case ExpressionType.MemberAccess: 

       MemberExpression memberExpression = (MemberExpression)propertySelector; 
       MemberInfo propertyInfo = memberExpression.Member; 

       if (memberExpression.Expression is ParameterExpression) 
       { 
        return propertyInfo.Name; 
       } 
       else 
       { 
        // we've got a nested property (e.g. MyType.SomeProperty.SomeNestedProperty) 
        return BuildString(memberExpression.Expression) + "/" + propertyInfo.Name; 
       } 

      case ExpressionType.Call: 
       MethodCallExpression methodCallExpression = (MethodCallExpression)propertySelector; 
       if (IsSubInclude(methodCallExpression.Method)) // check that it's a SubInclude call 
       { 
        // argument 0 is the expression to which the SubInclude is applied (this could be member access or another SubInclude) 
        // argument 1 is the expression to apply to get the included property 
        // Pass both to BuildString to get the full expression 
        return BuildString(methodCallExpression.Arguments[0]) + "/" + 
          BuildString(methodCallExpression.Arguments[1]); 
       } 
       // else drop out and throw 
       break; 
     } 
     throw new InvalidOperationException("Expression must be a member expression or an SubInclude call: " + propertySelector.ToString()); 

    } 

    private static readonly MethodInfo[] SubIncludeMethods; 
    static MyExtensions() 
    { 
     Type type = typeof(MyExtensions); 
     SubIncludeMethods = type.GetMethods().Where(mi => mi.Name == "SubExpand").ToArray(); 
    } 

    private static bool IsSubInclude(MethodInfo methodInfo) 
    { 
     if (methodInfo.IsGenericMethod) 
     { 
      if (!methodInfo.IsGenericMethodDefinition) 
      { 
       methodInfo = methodInfo.GetGenericMethodDefinition(); 
      } 
     } 
     return SubIncludeMethods.Contains(methodInfo); 
    } 

    public static TPropType SubExpand<TSource, TPropType>(this Collection<TSource> source, Expression<Func<TSource, TPropType>> propertySelector) 
     where TSource : class 
     where TPropType : class 
    { 
     throw new InvalidOperationException("This method is only intended for use with DataServiceQueryExtensions.Expand to generate expressions trees"); // no actually using this - just want the expression! 
    } 

    public static TPropType SubExpand<TSource, TPropType>(this TSource source, Expression<Func<TSource, TPropType>> propertySelector) 
     where TSource : class 
     where TPropType : class 
    { 
     throw new InvalidOperationException("This method is only intended for use with DataServiceQueryExtensions.Expand to generate expressions trees"); // no actually using this - just want the expression! 
    } 

Answer 1

경고는보다 단순하고 공개 된 인터페이스를 설계하는 데 도움이되는 일반적인 경고입니다. 이 경우 메서드에 Expression<Func<TElement, TPropType>> 매개 변수가 있음에 대한 경고 메시지가 나타납니다. 그러나이 방법을 사용하면 유형을 단순화 할 필요가 없으므로 attribute을 사용하여 경고를 억제하거나 규칙 집합에서 규칙을 완전히 제거해야합니다.

---

당신은 아마이 같은 방법 규칙의 조언되어 다음 사항을 고려한다 바보 예 :

public void F(Dictionary<String, List<Tuple<String, Int32>>> dictionary);